Module talk:Item

From Path of Exile Wiki
Revision as of 01:20, 29 August 2015 by >Lord joshi (→‎# of variations for hideout decorations: Decoration names like in shop or simple?)
Jump to navigation Jump to search

This talk page is for discussing Module:Item.

  • Sign your posts using four tildes (~~~~)
  • Start a new topic at the bottom under a ==level 2 heading==
  • Indent replies using colons (:)
  • Keep it civil
  • Assume good faith
  • Don't remove past discussions

Testing Changes

Is there a way to test changes to the module before applying them? I'd rather not edit the lua and break half the wiki.

In particular I wanted to add divination cards to the item module since they're missing currently and it makes sense to add them with their own display style as well, since they're strictly following a template. I.e. see this: http://omegak2.net/poe/2DItems_Divination_Images_1.dds

Could be replicated to just look like ingame. --OmegaK2 (talk) 10:50, 16 June 2015 (UTC)

You can use the sandbox module for testing. However, I was actually planning on implementing the divination cards myself. The only thing stopping me was that I didn't have beta access and therefore I wasn't able to extract the graphics. So thanks for that! —Vini (t|c) 11:37, 16 June 2015 (UTC)
Ah, okay if you go ahead and add it anyway, that will work. I have basic layout test here: User:OmegaK2/card_test --OmegaK2 (talk) 12:48, 16 June 2015 (UTC)
It might make sense to make the generic inline icon for the cards the inventory icon: . --OmegaK2 (talk) 14:41, 17 June 2015 (UTC)


Jewel radius and limit

I'm not familiar enough with the scripting language to modify this module, but a slight modification needs to be made to accommodate a jewel that has both a radius and a limit. Currently they display on the same line. This only affects Spire of Stone. TheMipchunk (talk) 07:26, 9 July 2015 (UTC)

# of variations for hideout decorations

Hideout decorations have a number of variations. Blue text. A horizontal line above and below. Atm it is possible to use RandomMods for that but it would be very nice to be able to write:

  • "Variations = 1" instead of "RandomMods = 1 Variation"
  • "Variations = 5" instead of "RandomMods = 5 Variations"
  • ...

I'd edit that myself but so far i don't understand the code enough to do that. And i really don't want to destroy the most important Module of the wiki. Not sure if that helps, but i think it would be good to make a new 'Type' for decorations. Since not all decorations are 'Microtrans'. I have created the page Falling Leaves Decoration to test the module. There you can also see, that there is an empty line above StackSize, imo because it doesn't have a Subtype, so that also needs to be fixed. Please send me a short message when it's done. Ty. --Lord joshi (talk)

On a side note, I can write up an item exporter for the decorations... should not be too complicated really which would save you a lot of trouble adding around 400 pages for decorations manually. --OmegaK2 (talk) 00:36, 26 August 2015 (UTC)
That would be very nice! I was thinking mainly about the microtransaction decorations. Didn't really plan to do all of them. But if you can do that, please do it and i'll just edit the decorations from the shop, if something is missing there. Oh, and i hope you are aware of the fact, that the name of the 2D art is mostly not the same as the name of the decoration ingame. --Lord joshi (talk)
I've added a decoration type to the item module. I've also moved your page to Falling Leaves (use _(Decoration) only when there is another page with the same name already). I haven't started work on exporting decorations yet, but it's certainly on the list of things to do. --OmegaK2 (talk) 22:51, 27 August 2015 (UTC)
Nice work. —Vini (t|c) 00:34, 28 August 2015 (UTC)
I was already thinking about using 'Decortation' or not. But i decided to keep the name from the shop, like it has been done already with pets, where all microtransactions are named '... Pet'. For sure it isn't necessary for the wiki to keep the 'Decoration' in the name, but i thought it would be best to use exactly the names from the shop. Oppinions? --Lord joshi (talk)