Template talk:Gem Infobox SMW: Difference between revisions

From Path of Exile Wiki
Jump to navigation Jump to search
>Teonlight-gpuser
>Adalace
(template Mana Multiplier field type "number" — no percent sign.)
Line 1: Line 1:
== Mana multiplier field type ==
The Mana Multiplier field takes a "number" type in this new template where the old template used strings. So obviously a format mismatch warning icon and tooltip appear next to the Mana Multiplier value if the argument is e.g. "140%" — we must use "140" instead. The problem is that a percent sign is never added to the final user-facing display value. I really think the percent sign is needed. If that requires changing the field type back to a string, it's still worth it. See [[Increased Area of Effect]] for an example. I removed the "%" from that template's argument to eliminate the warning icon and now it simply displays "140". I like this new template, but the whole thing should be considered carefully before a big rollout. Thanks for taking the time to work on this to make our wiki even better. —[[User:Adalace|Adalace]] ([[User_talk:Adalace|T]]|[[Special:Contributions/Adalace|C]]) 18:21, 29 March 2016 (UTC)
== Please don't change all pages yet ==
== Please don't change all pages yet ==


Line 16: Line 19:
--[[User:OmegaK2|OmegaK2]] ([[User_talk:OmegaK2|t]]|[[Special:Contributions/OmegaK2|c]]) 10:57, 11 March 2016 (UTC)
--[[User:OmegaK2|OmegaK2]] ([[User_talk:OmegaK2|t]]|[[Special:Contributions/OmegaK2|c]]) 10:57, 11 March 2016 (UTC)


== I completely agree however... ==
=== I completely agree however... ===


All of the updates and information about this were put into the community page nearly 7 months ago. The only implementation of SMW searchable properties is from the enchantment pages updated this patch.
All of the updates and information about this were put into the community page nearly 7 months ago. The only implementation of SMW searchable properties is from the enchantment pages updated this patch.

Revision as of 18:23, 29 March 2016

Mana multiplier field type

The Mana Multiplier field takes a "number" type in this new template where the old template used strings. So obviously a format mismatch warning icon and tooltip appear next to the Mana Multiplier value if the argument is e.g. "140%" — we must use "140" instead. The problem is that a percent sign is never added to the final user-facing display value. I really think the percent sign is needed. If that requires changing the field type back to a string, it's still worth it. See Increased Area of Effect for an example. I removed the "%" from that template's argument to eliminate the warning icon and now it simply displays "140". I like this new template, but the whole thing should be considered carefully before a big rollout. Thanks for taking the time to work on this to make our wiki even better. —Adalace (T|C) 18:21, 29 March 2016 (UTC)

Please don't change all pages yet

Hello, I like that you're reworking things, but the reason I didn't do this yet is that it should be done properly in the first place, otherwise every page is just changed multiple times.

Notes:

  • The attributes should be numbers, a lot of them are text right now
  • "Keywords" are called gem tags by the game.

Since you're sticking with the same template, it doesn't solve any of the issues:

  • quality stats don't exist per 1 quality, rather per 1000 quality divided down to the quality of the gem. Fractional bonuses don't exist and you can see this in game where for some gems for example you only gain something every 2 levels for instance. An better solution would be Q20 stats
  • In reality, allmost all stats a gem can change with the level of the skill; the template should support that. This means gem level progression and infobox should be one template.
  • Skills don't have to be a skill gem, but skill gems are always a skill. Regular skills do not have tags or specific requirements for example - this would be used on monsters skills or items giving skills for instance
  • It puts in the the effects of the skill gem but not the actual stats. The latter may be helpful for querying skills that meet certain conditions
  • It should probably use the proper gem visuals if it's skill gem, like User:OmegaK2/test2 (and this isn't finished and didn't solve any of above issues, hence it isn't used)
  • This should also be done in lua as it makes sanitizing the data easier and allows for inclusion in other files

--OmegaK2 (t|c) 10:57, 11 March 2016 (UTC)

I completely agree however...

All of the updates and information about this were put into the community page nearly 7 months ago. The only implementation of SMW searchable properties is from the enchantment pages updated this patch.

I'd like to continue forward with this template. Outputting data and tagging it for indexing later is a simple task too. If we're talking about a format change from what we have now, that will require ALOT of data entry at some point. I'll continue working on making this template smarter, and I definately like the idea of the in game artwork. I'll get to work on including that in the output of the template.

If you are absolutely against me proceeding forward I will stop but I think at this point having ANY indexed data will help us with pages like Area of effect since its missing things like Module Error: Too many skills found with q_where = skill.active_skill_name="Earthquake". Please choose only one of the following ids:
VikingBossQuakeSlamVinktars - 50% of Physical Damage Converted to Lightning Damage, Base duration is 3.00 seconds, Aftershock deals +75% more Damage with Hits and Ailments (page)
QuakeSlamGeneralAdusSupercharged - 50% of Physical Damage Converted to Lightning Damage, Base duration is 6.00 seconds, Base secondary duration is 1.05 seconds, 50% less Attack Speed, Aftershock deals +100% more Damage with Hits and Ailments (page)
and Module Error: Too many skills found with q_where = skill.active_skill_name="Ice Trap". Please choose only one of the following ids:
TalismanDaemonTrapIceRune - Deals (10-1673) to (14-2509) Cold Damage, Trap lasts +8 seconds, Traps are thrown randomly around targeted location, Throw up to (2-6) additional Traps, Base radius is 1.8 metres, Base secondary radius is 0.9 metres, Base tertiary radius is 0.6 metres (page)
IzaroDaemonIceTrap - Deals (11-1641) to (17-2462) Cold Damage, Trap lasts +6 seconds, Traps are thrown randomly around targeted location, Throw up to (2-4) additional Traps, Base radius is 1.8 metres, Base secondary radius is 0.9 metres, Base tertiary radius is 0.6 metres (page)
for example.

--Teonlight (t|c) 15:28 , 11 March 2016 (UTC)