Module talk:Item2

From Path of Exile Wiki
Revision as of 21:51, 1 September 2017 by >Molldust (Splitting the module)
Jump to navigation Jump to search

This talk page is for discussing Module:Item2.

  • Sign your posts using four tildes (~~~~)
  • Start a new topic at the bottom under a ==level 2 heading==
  • Indent replies using colons (:)
  • Keep it civil
  • Assume good faith
  • Don't remove past discussions

Star of Wraeclast

Now there is no Star of Wraeclast in unique amulet list, imho because it inherits drop disabled mark of its base type - Ruby Amulet. I think smth in this module need to be rewrited to fix it. Trympyrym (talk) 09:13, 12 May 2017 (UTC)

I disabled it from copying over from the base item because there are a few that are obtainable while the base items are not (except for vaaling I guess). This should fix for the time being, I'll get to making a proper fix for this eventually because the same issue could affect other properties that are copied from the base item --OmegaK2 (t|c) 17:10, 12 May 2017 (UTC)

Modifying skill gems tables to include sortable columns by tag

I was thinking about trying to modify this module so that skill gem tables would include sortable columns for each skill gem tag. For example on the Active Skill Gems page, we could be able to sort each column by which gems have the Attack tag or Minion tag. Does anyone have a general idea of how difficult would be? Does this sound like a worthwhile endeavor? Would anyone like to collaborate on this? Alleryn (talk) 20:30, 12 August 2017 (UTC)

There would be too many columns if you added one for each tag (over 30+ extra ones). A better solution would be with some javascript.--OmegaK2 (t|c) 21:42, 12 August 2017 (UTC)
Or what about snazzying up List_of_active_skill_gems_by_gem_tag and List_of_support_skill_gems_by_gem_tag, adding in some columns to show the minor attributes (e.g. if dex/int are needed on a red gem) and maybe some of the more relevant data like cast speed/crit chance/damage effectiveness. And then standardizing/templatizing (probably not a word) the pages that are list_of_x_gems, like List_of_skill_gems_dealing_spell_damage could be a part of a new page called List_of_spell_gems, which would also include List of Curses. Something like that. Does that sound like a reasonable approach for me to take? Thank you for your advice, OmegaK2 and any other respondents. Alleryn (talk) 02:59, 13 August 2017 (UTC)

Splitting the module

As mentioned it would be helpful to separate layout and backend. By layout I mean the item list/link. The backend consists of the item box and related code most likely.

Layout Item box (on item hover)
Module:Item link Module:Item
Module:Item list Module:Item list/skill gems by gem tag
Module:Item list/prophecies

This would have the benefit to not need to load the item list code for a simple item link. Furthermore new layouts such as prophecy lists for Prophecies can be designed without messing with Module:Item (or rather Module:Item2).