Module talk:Skill: Difference between revisions
Jump to navigation
Jump to search
>Irfy (Mark issue report as obsolete/fixed.) |
>Illviljan mNo edit summary |
||
| Line 1: | Line 1: | ||
==Mana cost header missing== | |||
<strike>The Mana Cost header isn't showing up for auras with flat mana reservation, like Clarity and Precision. I followed the code in this module visually and can't figure out what's wrong, the <code>map.progression.mana_cost.header</code> function seems to be called just fine from <code>p.progression</code>, and <code>has_reservation_mana_cost</code> is set for both mentioned aura skills -- that's as much as I can tell from afar. (Also, the <code>i18n.progression.mana_cost</code> header text seems to be mixed up with the %-based <code>...mana_reservation</code> header text. Compare that to the <code>i18n.infobox.mana_*</code> headers for flat vs % reservation auras -- these seem to be correct.)</strike> Fixed in 558790, thanks. [[User:Irfy|Irfy]] ([[User talk:Irfy|talk]]) 23:14, 23 June 2019 (UTC) | <strike>The Mana Cost header isn't showing up for auras with flat mana reservation, like Clarity and Precision. I followed the code in this module visually and can't figure out what's wrong, the <code>map.progression.mana_cost.header</code> function seems to be called just fine from <code>p.progression</code>, and <code>has_reservation_mana_cost</code> is set for both mentioned aura skills -- that's as much as I can tell from afar. (Also, the <code>i18n.progression.mana_cost</code> header text seems to be mixed up with the %-based <code>...mana_reservation</code> header text. Compare that to the <code>i18n.infobox.mana_*</code> headers for flat vs % reservation auras -- these seem to be correct.)</strike> Fixed in 558790, thanks. [[User:Irfy|Irfy]] ([[User talk:Irfy|talk]]) 23:14, 23 June 2019 (UTC) | ||
Latest revision as of 04:49, 26 June 2019
Mana cost header missing
The Mana Cost header isn't showing up for auras with flat mana reservation, like Clarity and Precision. I followed the code in this module visually and can't figure out what's wrong, the Fixed in 558790, thanks. Irfy (talk) 23:14, 23 June 2019 (UTC)
map.progression.mana_cost.header function seems to be called just fine from p.progression, and has_reservation_mana_cost is set for both mentioned aura skills -- that's as much as I can tell from afar. (Also, the i18n.progression.mana_cost header text seems to be mixed up with the %-based ...mana_reservation header text. Compare that to the i18n.infobox.mana_* headers for flat vs % reservation auras -- these seem to be correct.)